alex/yomichan
1
Fork 0
Code Releases Activity

Fix data-setting attributes not being updated on index change (#872)

Browse Source
This commit is contained in:
toasted-nutbread 2020-09-27 11:47:56 -04:00 committed by GitHub
parent cdd649ea3d
commit 3b6e3193ae
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
ext/bg/js/settings/scan-inputs-controller.js
View File

@ -135,6 +135,7 @@ class ScanInputField {
set index(value) { set index(value) {
this._index = value; this._index = value;
this._updateDataSettingTargets();
} }
prepare(container, include, exclude) { prepare(container, include, exclude) {
@ -158,10 +159,7 @@ class ScanInputField {
this._eventListeners.on(this._excludeInputField, 'change', this._onExcludeValueChange.bind(this)); this._eventListeners.on(this._excludeInputField, 'change', this._onExcludeValueChange.bind(this));
this._eventListeners.addEventListener(removeButton, 'click', this._onRemoveClick.bind(this)); this._eventListeners.addEventListener(removeButton, 'click', this._onRemoveClick.bind(this));
for (const typeCheckbox of node.querySelectorAll('.scan-input-settings-checkbox')) { this._updateDataSettingTargets();
const {property} = typeCheckbox.dataset;
typeCheckbox.dataset.setting = `scanning.inputs[${this._index}].${property}`;
}
} }
cleanup() { cleanup() {
@ -201,4 +199,12 @@ class ScanInputField {
const node = this._node.querySelector(`input.scan-input-settings-checkbox[data-property="types.${pointerType}"]`); const node = this._node.querySelector(`input.scan-input-settings-checkbox[data-property="types.${pointerType}"]`);
return node !== null && node.checked; return node !== null && node.checked;
} }
_updateDataSettingTargets() {
const index = this._index;
for (const typeCheckbox of this._node.querySelectorAll('.scan-input-settings-checkbox')) {
const {property} = typeCheckbox.dataset;
typeCheckbox.dataset.setting = `scanning.inputs[${index}].${property}`;
}
}
} }