From 29b6c98e9fa31e2397986bf0750f4b696a0051d5 Mon Sep 17 00:00:00 2001 From: toasted-nutbread Date: Thu, 14 Jan 2021 21:33:41 -0500 Subject: [PATCH] Clarify some settings descriptions (#1238) * Clarify the meaning of the 'None' option; rename to 'No key' * Clarify Auto-hide search popup * Clarify Scan delay * Move Support inputs for devices with touch screens; make advanced --- .../settings/scan-inputs-simple-controller.js | 2 +- ext/bg/settings2.html | 79 ++++++++++--------- ext/bg/welcome.html | 4 +- 3 files changed, 43 insertions(+), 42 deletions(-) diff --git a/ext/bg/js/settings/scan-inputs-simple-controller.js b/ext/bg/js/settings/scan-inputs-simple-controller.js index b6e56189..9e7eb5fc 100644 --- a/ext/bg/js/settings/scan-inputs-simple-controller.js +++ b/ext/bg/js/settings/scan-inputs-simple-controller.js @@ -106,7 +106,7 @@ class ScanInputsSimpleController { _populateSelect(select, hasOther) { const modifierKeys = [ - {value: 'none', name: 'None'}, + {value: 'none', name: 'No key'}, ...DocumentUtil.getModifierKeys(this._os).map(([value, name]) => ({value, name})) ]; diff --git a/ext/bg/settings2.html b/ext/bg/settings2.html index 641529db..11a2dad8 100644 --- a/ext/bg/settings2.html +++ b/ext/bg/settings2.html @@ -317,7 +317,8 @@ -
-
-
-
- Support inputs for devices with touch screens - (?) -
-
-
-
- - -
-
-
- -
Auto-hide search popup
-
When no text or definitions are found, the popup will automatically hide.
+
When no definitions are found after scanning text, the popup will automatically hide.
+
+
+
+
+ Support inputs for devices with touch screens + (?) +
+
+
+
+ + +
+
+
+ +
Configure input action prevention…
diff --git a/ext/bg/welcome.html b/ext/bg/welcome.html index 2c769e2b..1d02d6d9 100644 --- a/ext/bg/welcome.html +++ b/ext/bg/welcome.html @@ -129,7 +129,7 @@
Auto-hide search popup
-
When no text or definitions are found, the popup will automatically hide.
+
When no definitions are found after scanning text, the popup will automatically hide.