alex/yomichan
1
Fork 0
Code Releases Activity

Create function to create a new DOM parser (#1114)

Browse Source
This commit is contained in:
toasted-nutbread 2020-12-14 23:05:04 -05:00 committed by GitHub
parent 7926821c48
commit 26dd0270d9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
ext/bg/js/audio-downloader.js
View File

@ -109,7 +109,7 @@ class AudioDownloader {
}); });
const responseText = await response.text(); const responseText = await response.text();
const dom = new NativeSimpleDOMParser(responseText); const dom = this._createSimpleDOMParser(responseText);
for (const row of dom.getElementsByClassName('dc-result-row')) { for (const row of dom.getElementsByClassName('dc-result-row')) {
try { try {
const audio = dom.getElementByTagName('audio', row); const audio = dom.getElementByTagName('audio', row);
@ -149,7 +149,7 @@ class AudioDownloader {
}); });
const responseText = await response.text(); const responseText = await response.text();
const dom = new NativeSimpleDOMParser(responseText); const dom = this._createSimpleDOMParser(responseText);
try { try {
const audio = dom.getElementById(`audio_${expression}:${reading}`); const audio = dom.getElementById(`audio_${expression}:${reading}`);
if (audio !== null) { if (audio !== null) {
@ -237,4 +237,12 @@ class AudioDownloader {
_arrayBufferToBase64(arrayBuffer) { _arrayBufferToBase64(arrayBuffer) {
return btoa(String.fromCharCode(...new Uint8Array(arrayBuffer))); return btoa(String.fromCharCode(...new Uint8Array(arrayBuffer)));
} }
_createSimpleDOMParser(content) {
if (NativeSimpleDOMParser.isSupported()) {
return new NativeSimpleDOMParser(content);
} else {
throw new Error('DOM parsing not supported');
}
}
} }

4
ext/bg/js/native-simple-dom-parser.js
View File

@ -43,4 +43,8 @@ class NativeSimpleDOMParser {
getTextContent(element) { getTextContent(element) {
return element.textContent; return element.textContent;
} }
static isSupported() {
return typeof DOMParser !== 'undefined';
}
} }