alex/yomichan
1
Fork 0
Code Releases Activity

Fix incorrect selector causing invalid headword index to be used (#1705)

Browse Source
This commit is contained in:
toasted-nutbread 2021-05-23 13:20:38 -04:00 committed by GitHub
parent 41c0132c59
commit 24d43c123d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ext/js/display/display-audio.js
View File

@ -283,7 +283,7 @@ class DisplayAudio {
} }
_getAudioPlayButtonHeadwordIndex(button) { _getAudioPlayButtonHeadwordIndex(button) {
const headwordNode = button.closest('.expression'); const headwordNode = button.closest('.headword');
if (headwordNode !== null) { if (headwordNode !== null) {
const headwordIndex = parseInt(headwordNode.dataset.index, 10); const headwordIndex = parseInt(headwordNode.dataset.index, 10);
if (Number.isFinite(headwordIndex)) { return headwordIndex; } if (Number.isFinite(headwordIndex)) { return headwordIndex; }
@ -297,7 +297,7 @@ class DisplayAudio {
if (dictionaryEntryIndex >= 0 && dictionaryEntryIndex < dictionaryEntryNodes.length) { if (dictionaryEntryIndex >= 0 && dictionaryEntryIndex < dictionaryEntryNodes.length) {
const node = dictionaryEntryNodes[dictionaryEntryIndex]; const node = dictionaryEntryNodes[dictionaryEntryIndex];
const button1 = (headwordIndex === 0 ? node.querySelector('.action-play-audio') : null); const button1 = (headwordIndex === 0 ? node.querySelector('.action-play-audio') : null);
const button2 = node.querySelector(`.expression:nth-of-type(${headwordIndex + 1}) .action-play-audio`); const button2 = node.querySelector(`.headword:nth-of-type(${headwordIndex + 1}) .action-play-audio`);
if (button1 !== null) { results.push(button1); } if (button1 !== null) { results.push(button1); }
if (button2 !== null) { results.push(button2); } if (button2 !== null) { results.push(button2); }
} }