This commit is contained in:
Alex Yatskov 2017-03-16 22:13:54 -07:00
parent 8893db14ca
commit 231b471f45
2 changed files with 70 additions and 61 deletions

View File

@ -153,9 +153,12 @@ window.driver = new class {
const sentence = docSentenceExtract(textSource, this.options.anki.sentenceExt);
const url = window.location.href;
this.popup.showNextTo(textSource.getRect(), this.options);
this.popup.showTermDefs(definitions, this.options, {sentence, url});
this.popup.showTermDefs(
textSource.getRect(),
definitions,
this.options,
{sentence, url}
);
this.lastTextSource = textSource;
if (this.options.scanning.selectText) {
@ -176,9 +179,12 @@ window.driver = new class {
} else {
const sentence = docSentenceExtract(textSource, this.options.anki.sentenceExt);
const url = window.location.href;
this.popup.showNextTo(textSource.getRect(), this.options);
this.popup.showKanjiDefs(definitions, this.options, {sentence, url});
this.popup.showKanjiDefs(
textSource.getRect(),
definitions,
this.options,
{sentence, url}
);
this.lastTextSource = textSource;
if (this.options.scanning.selectText) {
@ -204,8 +210,7 @@ window.driver = new class {
handleError(error, textSource) {
if (window.orphaned) {
if (textSource && this.options.scanning.requireShift) {
this.popup.showNextTo(textSource.getRect(), this.options);
this.popup.showOrphaned();
this.popup.showOrphaned(textSource.getRect(), this.options);
}
} else {
window.alert(`Error: ${error}`);

View File

@ -26,29 +26,22 @@ class Popup {
this.container.setAttribute('src', chrome.extension.getURL('/fg/frame.html'));
this.container.style.width = '0px';
this.container.style.height = '0px';
this.injected = false;
this.injected = null;
}
inject() {
if (!this.injected) {
this.injected = new Promise((resolve, reject) => {
this.container.addEventListener('load', resolve);
document.body.appendChild(this.container);
this.injected = true;
}
});
}
showAt(rect) {
this.inject();
this.container.style.left = `${rect.x}px`;
this.container.style.top = `${rect.y}px`;
this.container.style.height = `${rect.height}px`;
this.container.style.width = `${rect.width}px`;
this.container.style.visibility = 'visible';
return this.injected;
}
showNextTo(elementRect, options) {
this.inject();
show(elementRect, options) {
return this.inject().then(() => {
const containerStyle = window.getComputedStyle(this.container);
const containerHeight = parseInt(containerStyle.height);
const containerWidth = parseInt(containerStyle.width);
@ -86,7 +79,12 @@ class Popup {
y = yBelow;
}
this.showAt({x, y, width, height});
this.container.style.left = `${x}px`;
this.container.style.top = `${y}px`;
this.container.style.width = `${width}px`;
this.container.style.height = `${height}px`;
this.container.style.visibility = 'visible';
});
}
hide() {
@ -97,16 +95,22 @@ class Popup {
return this.injected && this.container.style.visibility !== 'hidden';
}
showTermDefs(definitions, options, context) {
showTermDefs(elementRect, definitions, options, context) {
this.show(elementRect, options).then(() => {
this.invokeApi('showTermDefs', {definitions, options, context});
});
}
showKanjiDefs(definitions, options, context) {
showKanjiDefs(elementRect, definitions, options, context) {
this.show(elementRect, options).then(() => {
this.invokeApi('showKanjiDefs', {definitions, options, context});
});
}
showOrphaned() {
showOrphaned(elementRect, options) {
this.show(elementRect, options).then(() => {
this.invokeApi('showOrphaned');
});
}
invokeApi(action, params={}) {