alex/yomichan
1
Fork 0
Code Releases Activity

Fix missing details causing frequency tags to not be clickable (#1467)

Browse Source
This commit is contained in:
toasted-nutbread 2021-02-28 14:44:44 -05:00 committed by GitHub
parent 704db45e29
commit 1dfcd3e435
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
ext/js/display/display-generator.js
View File

@ -164,7 +164,11 @@ class DisplayGenerator {
createTagFooterNotificationDetails(tagNode) { createTagFooterNotificationDetails(tagNode) {
const node = this._templates.instantiateFragment('footer-notification-tag-details'); const node = this._templates.instantiateFragment('footer-notification-tag-details');
const details = tagNode.dataset.details; let details = tagNode.dataset.details;
if (typeof details !== 'string') {
const label = tagNode.querySelector('.tag-label-content');
details = label !== null ? label.textContent : '';
}
this._setTextContent(node.querySelector('.tag-details'), details); this._setTextContent(node.querySelector('.tag-details'), details);
let disambiguation = null; let disambiguation = null;
@ -602,6 +606,7 @@ class DisplayGenerator {
body.dataset.count = `${frequencyData.length}`; body.dataset.count = `${frequencyData.length}`;
node.dataset.count = `${frequencyData.length}`; node.dataset.count = `${frequencyData.length}`;
node.dataset.details = dictionary;
return node; return node;
} }
@ -624,6 +629,7 @@ class DisplayGenerator {
node.dataset.readingIsSame = `${reading === expression}`; node.dataset.readingIsSame = `${reading === expression}`;
node.dataset.dictionary = dictionary; node.dataset.dictionary = dictionary;
node.dataset.frequency = `${frequency}`; node.dataset.frequency = `${frequency}`;
node.dataset.details = dictionary;
return node; return node;
} }
@ -640,6 +646,7 @@ class DisplayGenerator {
node.dataset.character = character; node.dataset.character = character;
node.dataset.dictionary = dictionary; node.dataset.dictionary = dictionary;
node.dataset.frequency = `${frequency}`; node.dataset.frequency = `${frequency}`;
node.dataset.details = dictionary;
return node; return node;
} }