alex/yomichan
1
Fork 0
Code Releases Activity

use duck typing for event listener

Browse Source
This commit is contained in:
siikamiika 2020-04-04 16:59:17 +03:00
parent 067c26982e
commit 123e725049
1 changed files with 29 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
ext/mixed/js/core.js
View File

@ -325,7 +325,13 @@ const yomichan = (() => {
reject = _reject; reject = _reject;
}); });
if (eventHandler === chrome.runtime.onMessage) { if (
typeof eventHandler.addListener === 'undefined' ||
typeof eventHandler.removeListener === 'undefined'
) {
throw new Error('Event handler type not supported');
}
const runtimeMessageCallback = ({action, params}, sender, sendResponse) => { const runtimeMessageCallback = ({action, params}, sender, sendResponse) => {
let timeoutId = null; let timeoutId = null;
if (timeout !== null) { if (timeout !== null) {
@ -350,9 +356,6 @@ const yomichan = (() => {
}; };
eventHandler.addListener(runtimeMessageCallback); eventHandler.addListener(runtimeMessageCallback);
} else {
throw new Error('Event handler type not supported');
}
return listenerPromise; return listenerPromise;
} }