alex/yomichan
1
Fork 0
Code Releases Activity

Check type of other for equals functions

Browse Source 
Fixes #361
This commit is contained in:
toasted-nutbread 2020-02-15 20:52:21 -05:00
parent 217bd36abc
commit 10ec165f14
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
ext/fg/js/source.js
View File

@ -82,7 +82,11 @@ class TextSourceRange {
} }
equals(other) { equals(other) {
if (other === null) { if (!(
typeof other === 'object' &&
other !== null &&
other instanceof TextSourceRange
)) {
return false; return false;
} }
if (this.imposterSourceElement !== null) { if (this.imposterSourceElement !== null) {
@ -409,6 +413,12 @@ class TextSourceElement {
} }
equals(other) { equals(other) {
return other && other.element === this.element && other.content === this.content; return (
typeof other === 'object' &&
other !== null &&
other instanceof TextSourceElement &&
other.element === this.element &&
other.content === this.content
);
} }
} }