From 1078ab99b7a9d082ee36cbed69c8cb154db318b6 Mon Sep 17 00:00:00 2001 From: toasted-nutbread Date: Sat, 19 Sep 2020 17:15:34 -0400 Subject: [PATCH] Fix settings sanitization resulting in invalid data for the schema (#843) --- ext/bg/js/settings/backup-controller.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ext/bg/js/settings/backup-controller.js b/ext/bg/js/settings/backup-controller.js index 0676d451..80f83eb7 100644 --- a/ext/bg/js/settings/backup-controller.js +++ b/ext/bg/js/settings/backup-controller.js @@ -250,14 +250,14 @@ class BackupController { if (typeof fieldTemplates === 'string') { warnings.push('anki.fieldTemplates contains a non-default value'); if (!dryRun) { - delete anki.fieldTemplates; + anki.fieldTemplates = null; } } const server = anki.server; if (typeof server === 'string' && server.length > 0 && !this._isLocalhostUrl(server)) { warnings.push('anki.server uses a non-localhost URL'); if (!dryRun) { - delete anki.server; + anki.server = 'http://127.0.0.1:8765'; } } } @@ -268,7 +268,7 @@ class BackupController { if (typeof customSourceUrl === 'string' && customSourceUrl.length > 0 && !this._isLocalhostUrl(customSourceUrl)) { warnings.push('audio.customSourceUrl uses a non-localhost URL'); if (!dryRun) { - delete audio.customSourceUrl; + audio.customSourceUrl = ''; } } }