Add a script to patch bugs in dependencies (#1783)

This commit is contained in:
toasted-nutbread 2021-07-02 16:59:36 -04:00 committed by GitHub
parent 9c8f32d53f
commit 0c00c56e39
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 96 additions and 0 deletions

46
dev/patch-dependencies.js Normal file
View File

@ -0,0 +1,46 @@
/*
* Copyright (C) 2021 Yomichan Authors
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/
const fs = require('fs');
const assert = require('assert');
/**
* This function patches the following bug:
* * https://github.com/jsdom/jsdom/issues/3211
* * https://github.com/dperini/nwsapi/issues/48
*/
function patchNwsapi() {
const nwsapiPath = require.resolve('nwsapi');
const nwsapiSource = fs.readFileSync(nwsapiPath, {encoding: 'utf8'});
const pattern = /(if|while)(\()(?:e&&)?(\(e=e\.parentElement\)\)\{)/g;
let modifications = 0;
const nwsapiSourceNew = nwsapiSource.replace(pattern, (g0, g1, g2, g3) => {
++modifications;
return `${g1}${g2}e&&${g3}`;
});
assert.strictEqual(modifications, 2);
fs.writeFileSync(nwsapiPath, nwsapiSourceNew, {encoding: 'utf8'});
// nwsapi is used by JSDOM
const {testJSDOM} = require('../test/test-jsdom');
testJSDOM();
}
function main() {
patchNwsapi();
}
if (require.main === module) { main(); }

View File

@ -6,6 +6,7 @@
"test": "test" "test": "test"
}, },
"scripts": { "scripts": {
"postinstall": "node ./dev/patch-dependencies.js",
"build": "node ./dev/build.js", "build": "node ./dev/build.js",
"test": "npm run test-lint && npm run test-lint-css && npm run test-lint-html && npm run test-code && npm run test-manifest && npm run test-build", "test": "npm run test-lint && npm run test-lint-css && npm run test-lint-html && npm run test-code && npm run test-manifest && npm run test-build",
"test-lint": "npx eslint . && node ./dev/lint/global-declarations.js && node ./dev/lint/html-scripts.js", "test-lint": "npx eslint . && node ./dev/lint/global-declarations.js && node ./dev/lint/html-scripts.js",

49
test/test-jsdom.js Normal file
View File

@ -0,0 +1,49 @@
/*
* Copyright (C) 2021 Yomichan Authors
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/
const assert = require('assert');
const {testMain} = require('../dev/util');
/**
* This function tests the following bug:
* * https://github.com/jsdom/jsdom/issues/3211
* * https://github.com/dperini/nwsapi/issues/48
*/
function testJSDOMSelectorBug() {
// nwsapi is used by JSDOM
const {JSDOM} = require('jsdom');
const dom = new JSDOM();
const {document} = dom.window;
const div = document.createElement('div');
div.innerHTML = '<div class="b"><div class="c"></div></div>';
const c = div.querySelector('.c');
assert.doesNotThrow(() => { c.matches('.a:nth-last-of-type(1) .b .c'); });
}
function testJSDOM() {
testJSDOMSelectorBug();
}
function main() {
testJSDOM();
}
module.exports = {
testJSDOM
};
if (require.main === module) { testMain(main); }