alex/yomichan
1
Fork 0
Code Releases Activity

Show warning messages if persistant storage fails

Browse Source 
Only Firefox seems to support persistent storage properly.
This commit is contained in:
toasted-nutbread 2019-10-15 19:22:30 -04:00
parent 4443ad370e
commit 099909287f
3 changed files with 16 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ext/bg/css/settings.css
View File

@ -141,10 +141,10 @@
.btn-inner-middle { .btn-inner-middle {
vertical-align: middle; vertical-align: middle;
} }
.storage-persist-button-inner { .storage-button-inner {
pointer-events: none; pointer-events: none;
} }
input[type=checkbox]#storage-persist-button-checkbox { input[type=checkbox].storage-button-checkbox {
margin: 0 0.375em 0 0; margin: 0 0.375em 0 0;
padding: 0; padding: 0;
} }

6
ext/bg/js/settings.js
View File

@ -912,9 +912,7 @@ async function storagePersistInitialize() {
button.classList.remove('storage-hidden'); button.classList.remove('storage-hidden');
let persisted = await isStoragePeristent(); let persisted = await isStoragePeristent();
if (persisted) { checkbox.checked = persisted;
checkbox.checked = true;
}
button.addEventListener('click', async () => { button.addEventListener('click', async () => {
if (persisted) { if (persisted) {
@ -931,6 +929,8 @@ async function storagePersistInitialize() {
persisted = true; persisted = true;
checkbox.checked = true; checkbox.checked = true;
storageShowInfo(); storageShowInfo();
} else {
$('.storage-persist-fail-warning').removeClass('storage-hidden');
} }
}, false); }, false);
} }

12
ext/bg/settings.html
View File

@ -489,8 +489,18 @@
<div> <div>
<button class="btn btn-default" id="storage-refresh"><span class="btn-inner-middle">Refresh</span></button> <button class="btn btn-default" id="storage-refresh"><span class="btn-inner-middle">Refresh</span></button>
<button class="btn btn-default storage-hidden ignore-form-changes" id="storage-persist-button"><span class="storage-persist-button-inner"><input type="checkbox" class="btn-inner-middle" id="storage-persist-button-checkbox" readonly /><span class="btn-inner-middle">Persistent Storage</span></span></button> <button class="btn btn-default storage-hidden ignore-form-changes" id="storage-persist-button"><span class="storage-button-inner"><input type="checkbox" class="btn-inner-middle storage-button-checkbox" id="storage-persist-button-checkbox" readonly /><span class="btn-inner-middle">Persistent Storage</span></span></button>
</div> </div>
<p></p>
<div data-show-for-browser="firefox-mobile"><div class="alert alert-warning storage-persist-fail-warning storage-hidden">
<p>It may not be possible to enable Persistent Storage on Firefox for Android.</p>
</div></div>
<div data-show-for-browser="chrome"><div class="alert alert-warning storage-persist-fail-warning storage-hidden">
<p>It may not be possible to enable Persistent Storage on Chrome-based browsers.</p>
</div></div>
</div> </div>
<div> <div>