alex/yomichan
1
Fork 0
Code Releases Activity

Update how termTags is passed to _createTermExpression

Browse Source
This commit is contained in:
toasted-nutbread 2020-04-09 22:35:26 -04:00
parent bb37b74288
commit 06183ec124
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
ext/mixed/js/display-generator.js
View File

@ -68,9 +68,9 @@ class DisplayGenerator {
const termTags = details.termTags; const termTags = details.termTags;
let expressions = details.expressions; let expressions = details.expressions;
expressions = Array.isArray(expressions) ? expressions.map((e) => [e, termTags]) : [[details, termTags]]; expressions = Array.isArray(expressions) ? expressions : [details];
this._appendMultiple(expressionsContainer, this._createTermExpression.bind(this), expressions); this._appendMultiple(expressionsContainer, this._createTermExpression.bind(this), expressions, termTags);
this._appendMultiple(reasonsContainer, this._createTermReason.bind(this), details.reasons); this._appendMultiple(reasonsContainer, this._createTermReason.bind(this), details.reasons);
this._appendMultiple(frequenciesContainer, this._createFrequencyTag.bind(this), details.frequencies); this._appendMultiple(frequenciesContainer, this._createFrequencyTag.bind(this), details.frequencies);
this._appendMultiple(pitchesContainer, this._createPitches.bind(this), pitches); this._appendMultiple(pitchesContainer, this._createPitches.bind(this), pitches);
@ -130,7 +130,7 @@ class DisplayGenerator {
// Private // Private
_createTermExpression([details, termTags]) { _createTermExpression(details, termTags) {
const node = this._templateHandler.instantiate('term-expression'); const node = this._templateHandler.instantiate('term-expression');
const expressionContainer = node.querySelector('.term-expression-text'); const expressionContainer = node.querySelector('.term-expression-text');
@ -455,11 +455,11 @@ class DisplayGenerator {
); );
} }
_appendMultiple(container, createItem, detailsIterable) { _appendMultiple(container, createItem, detailsIterable, ...args) {
let count = 0; let count = 0;
if (container !== null && this._isIterable(detailsIterable)) { if (container !== null && this._isIterable(detailsIterable)) {
for (const details of detailsIterable) { for (const details of detailsIterable) {
const item = createItem(details); const item = createItem(details, ...args);
if (item === null) { continue; } if (item === null) { continue; }
container.appendChild(item); container.appendChild(item);
++count; ++count;